Eclipse File URL encoding is broken

I have been struggling with one issue raised to SAP Commerce eclipse plugin for a while and could not create test scenario to reproduce the bug #48

Fortunately one of users came up to situation that if file path to eclipse contains whitespace then it is not possible to convert Eclipse URL to File URL, then to URI to finally get a File instance pointing to local file. 

Long story short, whitespace should be encoded to format %20 to be compatible with standard. Currently (2020/2021 A.D.) it is not. I it is left as " "

Bit long, but unfortunately that scenario is quite often seen in plugin development. I was able to find on Eclipse Bugzilla #145096 and there was a struggle what to do with that... Until script has closed that bug. Bummer.

Last reply was:

Wrong. Non-encoded URLs are lossy. See explanations in bug 3109 comment 28. The only right solution is to stop using non-encoded URLs, even if that breaks buggy API clients that tried to "encode" wrong URLs (that "encoding" is not a well-defined process and hence cannot be supported). Code that tries to use org.eclipse.core.runtime.URIUtil#toURI(URL) is suspicious and shows that the author either didn't know how URLs work, or was forced to cope with broken APIs.
Where I fully agree with author, that working with broken API is a pain and brings a lot of swearing during debugging. Bug from 2016 is still there and no solution proposed.

Fortunately there is a workaround for that:


Comments

Post a Comment

Popular posts from this blog

SAP Commerce Cloud and Read-Only Replica

Image
 Introduction SAP Commerce Cloud introduced Read-Only Replicas as a standard feature for all production environments. Aim for Read-only data source is to offload batch queries or expensive ones from master data.  That data-source gives copy of same sized like master. When production runs on Premium P11 master, RO replica will be same, Premium P11 instance running side-by-side with master. Read-Only replica is available for all Premium DBs in CCv2. That is a standard functionality provided by Azure. Product Availability Feature is available from SAP Commerce Cloud version 1905 +.  With patches onward: 1905.37 , 2005.21 , 2011.16 , and 2105.6 . (You need to run update (aka 'Migrate Data') operation during deployment). CronJob and Job models have been extended and usage of replica has been simplified to a flag. This patch introduces the support for a read-only replica. The feature includes additional configuration options for the Backoffice search, task engine, Job/CronJob...
Read more

Eclipse plugin development and Apple Silicon M1

So... I have upgraded recently laptop to Macbook Pro M1. I am happy with hardware as it is blazing fast, cold, just perfect. But... I have issues with development. I am not going to mention, that my VMWare Fusion is not available on Apple Silicon and I am not able to test my eclipse plugin anymore on Windows 10, which is like... 80% of all users. Just maddness. When I decided to go with Apple Silicon I assumed, that VMWare will deliver Fusion pretty fast. I know there is beta released, but still I am not able to use it. Recently I have encountered an issue with architecture, when I tried to run my plugin in debug mode from Eclipse IDE. Let's check what problem I have: Eclipse RCP configuration looked like this: VM linked is embedded JRE: /Users/User/Develop/bin/EclipseRCP.app/Contents/Eclipse/plugins/org.eclipse.justj.openjdk.hotspot.jre.full.macosx.aarch64_17.0.2.v20220201-1208/jre/lib/libjli.dylib Solution for mixing architecture on Eclipse Debug Mode The reason of...
Read more

FlexibleSearch Pagination

SAP Commerce platform provides functionality for pagination DB results. You are able to find paginated DAO: There is also Flexible Service which also allows pagination: That implementation depends on other DTOs i.e: PaginatedFlexibleSearchParameter and SearchPageData : Usage of that code is not popular in platform. Can be found in few places (I will update that part later on) but what is most important here, it is not easiest solution at all! Solution for pagination So how to make it better, with no hassle with extra helper objects? Just use what FlexibleSearchQuery class gives to you. FlexibleSearchQuery gives you 2 methods setStart and setCount thanks to that you are able to set up pagination functionality in code. SAP API Documentation FlexibleSearchQuery
Read more